fix: GeneaLabs/laravel-model-caching issue #448 #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkCooldownAndFlushAfterPersisting(): Argument mikebronner#2 ($relationship) must be of type string, array given, called in /var/www/html/vendor/genealabs/laravel-model-caching/src/Traits/ModelCaching.php on line 83
mikebronner
approved these changes
Mar 27, 2023
JamesPJ
added a commit
to JamesPJ/laravel-model-caching
that referenced
this pull request
Dec 12, 2024
JamesPJ
added a commit
to JamesPJ/laravel-model-caching
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolved an error we were receiving when using attach() or detach() on a Model relationship after upgrading to Laravel 10. This patch seems to fix a bug introduced by this commit: mikebronner/laravel-pivot-events@862371f
Relevant package versions:
We were receiving the same error described in issue #448:
Prior to this patch, I confirmed Argument # 2 ($relationship) contained an array of record IDs. After this patch, I confirmed Argument # 2 ($relationship) contained a string with the relationship name. The Model cache appears to be updated as expected after attach() and detach() events.
I was unable to run the package's test suite. This package seems to require Laravel Nova? I do not have a Nova license. Running
composer installwithin this package directory prompts for a Laravel Nova login.